feat: add styling for new footer component #916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
TrymVei
force-pushed
the
feat/v3-new-footer
branch
from
0ff2169 to
31f0ab0
Compare
|
Starting to look good! should this have max width also? |
mikaelbr
reviewed
Dec 10, 2024
|
|
||
| {soMeData && ( | ||
| <FooterSection title={t("socialMedia")}> | ||
| {renderSoMe(navigationData, soMeData)} |
There was a problem hiding this comment.
Typically this should be a component to utilise react properly, but can be fixed later
There was a problem hiding this comment.
Yep, there are also a few things that can be done to make this more dynamic and utilize the connection to Sanity better, but I would rather get a version of this out now, and then we can make it even better later 👌
Regarding max-width I wasn't quite sure if it should have it or not, as some footers span the width of the page, but it won't be a problem to add it if we see that it's too big in relation to other content
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Created a new footer component
Figma
https://www.figma.com/design/zgXtEvibcgxxvdMDBBaICD/Ny-variant.no%2Fse?node-id=3825-28533&m=dev
Screenshots
Mobile
Tablet
Desktop